Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#27): Add dbt unit test brac #28

Merged
merged 44 commits into from
Nov 1, 2023
Merged

chore(#27): Add dbt unit test brac #28

merged 44 commits into from
Nov 1, 2023

Conversation

lorerod
Copy link
Contributor

@lorerod lorerod commented Sep 19, 2023

Add unit test to BRAC dbt models

closes #27

@lorerod lorerod changed the base branch from main to BRAC-models October 18, 2023 11:54
Maria Lorena Rodriguez Viruel added 22 commits October 18, 2023 13:34
Merge with 30-fix-failing-brac-models
be804cd
Add tests for contact_views models
ff34b9b
Add tests to useviews models
abf1b27
Fix some test
3e2d808
Add tests for main models
1a07e87
Add relationships and accepted_values tests
bec08a7
Add relationships tests on contact views models
c23c2fd
Add relationships tests to main models
69a1942
Fix Did not find matching node for patch error
1c0f18c
Fix accepted values errors
532fb73
Fix tests
3c3498a
Fixing failing tests
261768d
Delete some failing tests
63feb64
First views model test
5ce7ac8
Add useviews model tests
349016c
Change the way columns are referenced in couchdb
0e61edf
Trying to see if the problem are the seeds
5da2bbb
Add test to pncview_actual_enrrollments model
77d71fd
Add test for form_metadata model
6ae98d8
Add test for impactview_month
efc1e0a
Add test to formview_inmunization_follow_up model
ac99bb4
Add test for formview_assessment_follow_up model
c77e687
@lorerod lorerod marked this pull request as ready for review October 23, 2023 17:08
@lorerod
Copy link
Contributor Author

lorerod commented Oct 23, 2023 •
edited
Loading

Hi reviewers! I implemented a pretty straightforward test on each of the BRAC models. If you have time, you can learn about dbt unit test here.
I also made a summary in this short video.
I hope to find a way to calculate test coverage. I will let you know if I do.
Also, a couple of important details about this PR. The changes on .sql files were made by @njuguna-n to fix models that were not compiling. The change is going to be merge to BRAC-models branch, not main branch.
Thanks!

andrablaj
andrablaj approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to run the unit tests successfully. Nevertheless, I didn't check the test coverage resources you shared. I think this is already a good start for learning how to set up the unit tests for dbt.

Screenshot 2023-10-26 at 13 48 40

andrablaj
andrablaj reviewed Oct 26, 2023
View reviewed changes
tests/run_dbt_tests.sh Outdated Show resolved Hide resolved
@lorerod
Copy link
Contributor Author

lorerod commented Nov 1, 2023

@andrablaj I will configure the project to check for test coverage on this issue.

@lorerod lorerod merged commit 194b3d5 into BRAC-models Nov 1, 2023
2 checks passed
@lorerod lorerod deleted the 27-add-dbt-unit-test-brac branch November 1, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrablaj andrablaj andrablaj approved these changes

@tatilepizs tatilepizs Awaiting requested review from tatilepizs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dbt unit test for BRAC models
3 participants
@lorerod @andrablaj @njogz